You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Martin Cooper (JIRA)" <ji...@codehaus.org> on 2008/11/17 02:34:15 UTC
[jira] Created: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
RepositoryServlet tests fail intermittently on Windows
------------------------------------------------------
Key: MRM-1004
URL: http://jira.codehaus.org/browse/MRM-1004
Project: Archiva
Issue Type: Bug
Components: build
Affects Versions: 1.2-M1
Environment: Windows
Reporter: Martin Cooper
Attachments: close_reader.patch
The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
Posted by "James William Dumay (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay reassigned MRM-1004:
----------------------------------------
Assignee: James William Dumay
> RepositoryServlet tests fail intermittently on Windows
> ------------------------------------------------------
>
> Key: MRM-1004
> URL: http://jira.codehaus.org/browse/MRM-1004
> Project: Archiva
> Issue Type: Bug
> Components: build
> Affects Versions: 1.2-M1
> Environment: Windows
> Reporter: Martin Cooper
> Assignee: James William Dumay
> Attachments: close_reader.patch
>
>
> The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
> Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
> Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
Posted by "James William Dumay (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay updated MRM-1004:
-------------------------------------
Fix Version/s: 1.2
> RepositoryServlet tests fail intermittently on Windows
> ------------------------------------------------------
>
> Key: MRM-1004
> URL: http://jira.codehaus.org/browse/MRM-1004
> Project: Archiva
> Issue Type: Bug
> Components: build
> Affects Versions: 1.2-M1
> Environment: Windows
> Reporter: Martin Cooper
> Assignee: James William Dumay
> Fix For: 1.2
>
> Attachments: close_reader.patch
>
>
> The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
> Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
> Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
Posted by "James William Dumay (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James William Dumay closed MRM-1004.
------------------------------------
Resolution: Fixed
Committed in 718157.
Thanks for that patch Martin. Thats a big oop's.
> RepositoryServlet tests fail intermittently on Windows
> ------------------------------------------------------
>
> Key: MRM-1004
> URL: http://jira.codehaus.org/browse/MRM-1004
> Project: Archiva
> Issue Type: Bug
> Components: build
> Affects Versions: 1.2-M1
> Environment: Windows
> Reporter: Martin Cooper
> Assignee: James William Dumay
> Attachments: close_reader.patch
>
>
> The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
> Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
> Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Odea Ching updated MRM-1004:
----------------------------------
Fix Version/s: (was: 1.2-M2)
1.2
> RepositoryServlet tests fail intermittently on Windows
> ------------------------------------------------------
>
> Key: MRM-1004
> URL: http://jira.codehaus.org/browse/MRM-1004
> Project: Archiva
> Issue Type: Bug
> Components: build
> Affects Versions: 1.2-M1
> Environment: Windows
> Reporter: Martin Cooper
> Assignee: James William Dumay
> Fix For: 1.2
>
> Attachments: close_reader.patch
>
>
> The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
> Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
> Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MRM-1004) RepositoryServlet tests fail
intermittently on Windows
Posted by "James William Dumay (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRM-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MRM-1004 started by James William Dumay.
> RepositoryServlet tests fail intermittently on Windows
> ------------------------------------------------------
>
> Key: MRM-1004
> URL: http://jira.codehaus.org/browse/MRM-1004
> Project: Archiva
> Issue Type: Bug
> Components: build
> Affects Versions: 1.2-M1
> Environment: Windows
> Reporter: Martin Cooper
> Assignee: James William Dumay
> Attachments: close_reader.patch
>
>
> The repository servlet tests (e.g. RepositoryServletProxiedRelocatedTest) fail on Windows due to a bug in a Maven class (MavenXpp3Reader) that Archiva is using. The bug is that MavenXpp3Reader does not close the Reader after reading the content of a POM. Thus the file is left open until the MavenXpp3Reader instance is garbage collected. Since the garbage collector is run whenever the JVM feels like it, the problem is intermittent rather than being consistent.
> Although the root of the problem is with Maven's MavenXpp3Reader class, there is a simple workaround that can be applied to the Archiva code. That is to close the reader explicitly, after the POM content has been read. This will not cause a problem when the Maven bug is fixed, since closing an already-closed Reader is a no-op.
> Patch attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira