[jira] [Commented] (HBASE-6834) HBaseClusterManager shell code breaks hadoop-2.0 build

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458347#comment-13458347 ] 

Enis Soztutar commented on HBASE-6834:
--------------------------------------

Thanks for spotting this. I'll provide a patch for changing the signature. 
                
> HBaseClusterManager shell code breaks hadoop-2.0 build
> ------------------------------------------------------
>
>                 Key: HBASE-6834
>                 URL: https://issues.apache.org/jira/browse/HBASE-6834
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Gregory Chanan
>            Assignee: Enis Soztutar
>
> I get the following error:
> {noformat}
> HBaseClusterManager.java:[73,23] getExecString() in org.apache.hadoop.hbase.HBaseClusterManager.RemoteShell cannot override getExecString() in org.apache.hadoop.util.Shell.ShellCommandExecutor; attempting to assign weaker access privileges; was public
> {noformat}
> the issue is that getExecString() is declared public in hadoop-2.0, but protected in hadoop-1.0.  In HBase, it is declared protected, and you can't downgrade from public to protected.
> We can just declare the function public and that seems to work, but given that in hadoop the class is declared
> {code}
> @InterfaceAudience.LimitedPrivate({"HDFS", "MapReduce"})
> {code}
> perhaps we should just copy the class into hbase source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira