You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/08/06 03:48:40 UTC

[GitHub] liubao68 commented on a change in pull request #851: [SCB-782]support revision check when use pull mode with config center

liubao68 commented on a change in pull request #851:  [SCB-782]support revision check when use pull mode with config center
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851#discussion_r207768610
 
 

 ##########
 File path: dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ParseConfigUtils.java
 ##########
 @@ -40,32 +42,56 @@
 
   public static final Map<String, Object> flatItems = new HashMap<>();
 
+  public static String CURRENT_VERSION_INFO = "default";
 
 Review comment:
   1. Do not use public static field. 
   2. Non final field should be lower case. Only final field be upper case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services