You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/24 09:42:35 UTC
[GitHub] [dubbo-spi-extensions] goodjava opened a new pull request #71: Add quic protocol support
goodjava opened a new pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71
Add quic protocol support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] AlbumenJ commented on a change in pull request #71: Add quic protocol support
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on a change in pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71#discussion_r716594524
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Please add ASF license header
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>dubbo-remoting-extensions</artifactId>
+ <groupId>org.apache.dubbo.extensions</groupId>
+ <version>${revision}</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>dubbo-remoting-quic</artifactId>
+
+
+ <dependencies>
+
+ <dependency>
+ <groupId>io.netty.incubator</groupId>
+ <artifactId>netty-incubator-codec-quic</artifactId>
+ <version>0.0.14.Final</version>
+ <classifier>osx-x86_64</classifier>
Review comment:
should this classifier change to some env variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] AlbumenJ merged pull request #71: Add quic protocol support
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] goodjava commented on a change in pull request #71: Add quic protocol support
Posted by GitBox <gi...@apache.org>.
goodjava commented on a change in pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71#discussion_r717266155
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
get
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>dubbo-remoting-extensions</artifactId>
+ <groupId>org.apache.dubbo.extensions</groupId>
+ <version>${revision}</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>dubbo-remoting-quic</artifactId>
+
+
+ <dependencies>
+
+ <dependency>
+ <groupId>io.netty.incubator</groupId>
+ <artifactId>netty-incubator-codec-quic</artifactId>
+ <version>0.0.14.Final</version>
+ <classifier>osx-x86_64</classifier>
Review comment:
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] AlbumenJ merged pull request #71: Add quic protocol support
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] goodjava commented on a change in pull request #71: Add quic protocol support
Posted by GitBox <gi...@apache.org>.
goodjava commented on a change in pull request #71:
URL: https://github.com/apache/dubbo-spi-extensions/pull/71#discussion_r717266155
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
get
##########
File path: dubbo-remoting-extensions/dubbo-remoting-quic/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>dubbo-remoting-extensions</artifactId>
+ <groupId>org.apache.dubbo.extensions</groupId>
+ <version>${revision}</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>dubbo-remoting-quic</artifactId>
+
+
+ <dependencies>
+
+ <dependency>
+ <groupId>io.netty.incubator</groupId>
+ <artifactId>netty-incubator-codec-quic</artifactId>
+ <version>0.0.14.Final</version>
+ <classifier>osx-x86_64</classifier>
Review comment:
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org