You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/03 08:14:08 UTC

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4083: docs(github): add comment for collector using since

warren830 commented on code in PR #4083:
URL: https://github.com/apache/incubator-devlake/pull/4083#discussion_r1060350654


##########
plugins/github/tasks/comment_collector.go:
##########
@@ -56,6 +56,9 @@ func CollectApiComments(taskCtx core.SubTaskContext) errors.Error {
 			query.Set("state", "all")
 			// if data.CreatedDateAfter != nil, we set since once
 			if data.CreatedDateAfter != nil {
+				// Actually we should use create instead of since, but this api only has since as query param

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org