[jira] [Commented] (FLINK-31208) KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)

["Qingsheng Ren (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-31208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752253#comment-17752253 ] 

Qingsheng Ren commented on FLINK-31208:
---------------------------------------

Merged to apache/flink-connector-kafka:main

d6525c1481fc2d2821f361d2d5ce48f97221dd74

> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-31208
>                 URL: https://issues.apache.org/jira/browse/FLINK-31208
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka
>    Affects Versions: kafka-3.0.0
>            Reporter: Hongshun Wang
>            Assignee: Hongshun Wang
>            Priority: Not a Priority
>              Labels: pull-request-available, starter
>             Fix For: kafka-3.0.1
>
>
> KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) ，which is no difference with its Parent class (SourceReaderBase). why not remove this override method?
>  
> Relative code is here, which we can see is no difference?
> {code:java}
> //org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
>         Collection<String> splitsToPause, Collection<String> splitsToResume) {
>     splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> } 
> //org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
> @Override
> public void pauseOrResumeSplits(
>         Collection<String> splitsToPause, Collection<String> splitsToResume) {
>     splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)