You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2025/10/17 07:52:55 UTC
[PR] Make MAL percentile align with OAL percentile calculation and update Grafana dashboards for OAP observability. [skywalking]
wankai123 opened a new pull request, #13546:
URL: https://github.com/apache/skywalking/pull/13546
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MAL percentile align with OAL percentile calculation and update Grafana dashboards for OAP observability. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13546:
URL: https://github.com/apache/skywalking/pull/13546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make MAL percentile align with OAL percentile calculation and update Grafana dashboards for OAP observability. [skywalking]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13546:
URL: https://github.com/apache/skywalking/pull/13546#discussion_r2438734156
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-http1-value-label.yml:
##########
@@ -62,6 +62,21 @@ results:
owner: null
traceid: null
{{- end}}
+ - metric:
+ labels:
+ - key: p
+ value: "95"
+ values:
+ { { - contains .values } }
+ - id: { { notEmpty .id } }
+ value: { { .value } }
+ owner: null
+ traceid: null
+ - id: { { notEmpty .id } }
+ value: null
+ owner: null
+ traceid: null
+ { { - end } }
Review Comment:
The Go template delimiters have extra spaces, breaking the expected result template parsing. Replace them with the correct delimiters, e.g., use "{{- contains .values }}", "- id: {{ notEmpty .id }}", "value: {{ .value }}", and "{{- end }}".
```suggestion
{{- contains .values }}
- id: {{ notEmpty .id }}
value: {{ .value }}
owner: null
traceid: null
- id: {{ notEmpty .id }}
value: null
owner: null
traceid: null
{{- end}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org