[GitHub] [tomee] rmannibucau commented on pull request #1059: TOMEE-4226 - Check for modern PostgreSQL driver, if JDBCUrl is not specified in @DataSourceDefinition

["rmannibucau (via GitHub)" <gi...@apache.org>]

rmannibucau commented on PR #1059:
URL: https://github.com/apache/tomee/pull/1059#issuecomment-1609073330

   if it helps, my two cents would be it can be worth adding a DataSourceDefinitionUrlBuild openejb event since these guessed URL are rarely prod friendly urls so firing the event with the data we have (from the annot) and allowing to set an URL can be a way to enable users to customize the way the url is built (plugin like) then supporting by default all world patterns become less important since there are several cases we just have to do a choice so 50% it can be wrong ;).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org