You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/01/19 02:01:57 UTC
[GitHub] [hive] maheshk114 commented on a change in pull request #2943: HIVE-25864 : Hive query optimisation creates wrong plan for predicate pushdown with windowing function
maheshk114 commented on a change in pull request #2943:
URL: https://github.com/apache/hive/pull/2943#discussion_r787291853
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java
##########
@@ -170,6 +171,7 @@ public void onMatch(RelOptRuleCall call) {
if (HiveCalciteUtil.isDeterministicFuncWithSingleInputRef(newCondition,
commonPartitionKeys)) {
newPartKeyFilConds.add(newCondition);
+ isConversionDone = true;
Review comment:
I was also thinking that way to keep the code clean, But there will be two conversion ..one to check if its deterministic and one more for the projection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org