[GitHub] [incubator-pinot] mcvsubbu commented on issue #4321: #4317 Feature/variable length bytes offline dictionary for indexing bytes and string dicts.

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #4321: #4317 Feature/variable length bytes offline dictionary for indexing bytes and string dicts.
URL: https://github.com/apache/incubator-pinot/pull/4321#issuecomment-504479121
 
 
   @buchireddy , @kishoreg please provide your comments on https://github.com/apache/incubator-pinot/pull/4348. I need a ship-it from one of you
   
   I have not addressed most of the comments by @mayankshriv which will be in the implementation of VarLengthBytesValueReaderWriter.   Basically, my proposal is to build mutable and immutable versions of OffHeapByteArrayStore. Either we can derive two classes out of this and use them, or we can play around with the ctor of OffHeapByteArraystore to make it independent of memory manager etc. (caller allocates) and provide only a pnot-databuffer that is mutable (vs the immutable, which could then becoime an empty constructor with an init call). We can work around these things. All I want is one way to encode strings in a compact fashion. thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org