You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/02 10:48:23 UTC

[GitHub] [cordova-android] knight9999 opened a new pull request #1307: fix: backbutton test code

knight9999 opened a new pull request #1307:
URL: https://github.com/apache/cordova-android/pull/1307


   
   ### Platforms affected
   android
   
   
   ### Motivation and Context
   Fix the issue of `BackButtonMultipageTest`.
   
   ### Description
   Adding `throws Throwable` in the `assertPageSample` methods
   in order to fix the test error.
   
   ### Testing
   Do 
   ```
   % npm run java-tests
   ```
   in my local environment (mac).
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] erisu merged pull request #1307: fix: backbutton test code

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1307:
URL: https://github.com/apache/cordova-android/pull/1307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org