You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Xu Mingmin (JIRA)" <ji...@apache.org> on 2017/08/24 17:19:00 UTC
[jira] [Closed] (BEAM-2798) rename simpleQuery to query and query
to queryMulti
[ https://issues.apache.org/jira/browse/BEAM-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xu Mingmin closed BEAM-2798.
----------------------------
Resolution: Fixed
Assignee: Xu Mingmin
Fix Version/s: Not applicable
> rename simpleQuery to query and query to queryMulti
> ---------------------------------------------------
>
> Key: BEAM-2798
> URL: https://issues.apache.org/jira/browse/BEAM-2798
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Labels: dsl_sql_merge, dsl_sql_review
> Fix For: Not applicable
>
>
> One other question from playing around with things more: simpleQuery vs query method names. Would it be better if they were named query and queryMulti, respectively? Two potential reasons why that might be better: 1) make simple things simple, e.g., the single input version should be simpler to express. 2) method names typically should be actions/verbs, but simpleQuery makes it sound like a noun/object.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)