You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@paimon.apache.org by "tsreaper (via GitHub)" <gi...@apache.org> on 2024/01/25 04:53:00 UTC

[PR] [core] Make PrimaryKeyFileStoreTable and AppendOnlyFileStoreTable package private [incubator-paimon]

tsreaper opened a new pull request, #2791:
URL: https://github.com/apache/incubator-paimon/pull/2791

   ### Purpose
   
   This PR makes `PrimaryKeyFileStoreTable` and `AppendOnlyFileStoreTable` package private classes. Developers should use `FileStoreTable` interface instead and check if the table has primary keys.
   
   ### Tests
   
   This PR is a refactor without tests.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Make PrimaryKeyFileStoreTable and AppendOnlyFileStoreTable package private [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.

JingsongLi merged PR #2791:
URL: https://github.com/apache/incubator-paimon/pull/2791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] Make PrimaryKeyFileStoreTable and AppendOnlyFileStoreTable package private [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.

JingsongLi commented on PR #2791:
URL: https://github.com/apache/incubator-paimon/pull/2791#issuecomment-1909651465

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org