You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/01 14:00:53 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3854: [ISSUE #3852]Replace some logic with existing APIs. Merge some logic.
pandaapo opened a new pull request, #3854:
URL: https://github.com/apache/eventmesh/pull/3854
Fixes #3852.
### Motivation
See detail in issue "Enhancement Request"
### Modifications
See detail in issue "Describe the solution you'd like".
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3854: [ISSUE #3852]Replace some logic with existing APIs. Merge some logic.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3854:
URL: https://github.com/apache/eventmesh/pull/3854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3854: [ISSUE #3852]Replace some logic with existing APIs. Merge some logic.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3854:
URL: https://github.com/apache/eventmesh/pull/3854#issuecomment-1535836090
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3854](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e529855) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **increase** coverage by `0.00%`.
> The diff coverage is `7.14%`.
> :exclamation: Current head e529855 differs from pull request most recent head 68c0c22. Consider uploading reports for the commit 68c0c22 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3854 +/- ##
=========================================
Coverage 13.77% 13.78%
Complexity 1290 1290
=========================================
Files 571 571
Lines 29129 29089 -40
Branches 2837 2839 +2
=========================================
- Hits 4012 4009 -3
+ Misses 24745 24705 -40
- Partials 372 375 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...olver/http/SendMessageBatchV2ProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlQmF0Y2hWMlByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...olver/http/SendMessageRequestProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9odHRwL1NlbmRNZXNzYWdlUmVxdWVzdFByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ssage/resolver/tcp/TcpMessageProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci90Y3AvVGNwTWVzc2FnZVByb3RvY29sUmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mesh/storage/kafka/consumer/KafkaConsumerImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvc3RvcmFnZS9rYWZrYS9jb25zdW1lci9LYWZrYUNvbnN1bWVySW1wbC5qYXZh) | `9.09% <ø> (ø)` | |
| [.../knative/cloudevent/impl/KnativeMessageWriter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWtuYXRpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVNZXNzYWdlV3JpdGVyLmphdmE=) | `61.11% <0.00%> (ø)` | |
| [...eventmesh/storage/pravega/PravegaConsumerImpl.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvUHJhdmVnYUNvbnN1bWVySW1wbC5qYXZh) | `16.66% <ø> (ø)` | |
| [...torage/pravega/client/PravegaCloudEventWriter.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FDbG91ZEV2ZW50V3JpdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...standalone/consumer/StandaloneConsumerAdaptor.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXN0YW5kYWxvbmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/trace/jaeger/JaegerTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtamFlZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvamFlZ2VyL0phZWdlclRyYWNlU2VydmljZS5qYXZh) | `60.00% <ø> (ø)` | |
| [...eventmesh/trace/pinpoint/PinpointTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtcGlucG9pbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC90cmFjZS9waW5wb2ludC9QaW5wb2ludFRyYWNlU2VydmljZS5qYXZh) | `52.17% <ø> (ø)` | |
| ... and [3 more](https://app.codecov.io/gh/apache/eventmesh/pull/3854?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3854/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org