You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "PDavid (via GitHub)" <gi...@apache.org> on 2024/12/05 09:00:26 UTC
Re: [PR] HBASE-28627 REST ScannerModel doesn't support includeStartRow/include… [hbase]
PDavid commented on code in PR #6374:
URL: https://github.com/apache/hbase/pull/6374#discussion_r1870940303
##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java:
##########
@@ -135,7 +135,9 @@ public TableScanResource getScanResource(final @PathParam("scanspec") String sca
@DefaultValue("true") @QueryParam(Constants.SCAN_CACHE_BLOCKS) boolean cacheBlocks,
@DefaultValue("false") @QueryParam(Constants.SCAN_REVERSED) boolean reversed,
@QueryParam(Constants.FILTER) String paramFilter,
- @QueryParam(Constants.FILTER_B64) @Encoded String paramFilterB64) {
+ @QueryParam(Constants.FILTER_B64) @Encoded String paramFilterB64,
+ @DefaultValue("true") @QueryParam(Constants.SCAN_INCLUDE_START_ROW) boolean includeStartRow,
+ @DefaultValue("false") @QueryParam(Constants.SCAN_INCLUDE_STOP_ROW) boolean includeStopRow) {
Review Comment:
I know that this is PR is already merged but maybe it would make sense to also log these new parameters in the trace log statement a bit below. Maybe this could be added in the followup PR: https://github.com/apache/hbase/pull/6499
What do you think @chandrasekhar-188k ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org