You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2025/02/11 08:51:52 UTC
[PR] Add ATProtocol handle resolution file [arrow-site]
pitrou opened a new pull request, #587:
URL: https://github.com/apache/arrow-site/pull/587
This should allow our BlueSky account to use the handle "@arrow.apache.org".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #587:
URL: https://github.com/apache/arrow-site/pull/587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #587:
URL: https://github.com/apache/arrow-site/pull/587#discussion_r1950605932
##########
_config.yml:
##########
@@ -25,6 +25,7 @@ kramdown:
include:
- _static
+ - .well-known
Review Comment:
The addition ensures that the `.well-known` directory and its contents is included in the generated site.
Is there a reason to prefer a shell `cp` command? I find it cleaner to rely as much as possible on configuration, rather than dedicated shell commands. Also, using `_config.yml` I could actually test my changes locally.
@kou What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #587:
URL: https://github.com/apache/arrow-site/pull/587#issuecomment-2650512672
Ok, let's merge and check that this did work as expected!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #587:
URL: https://github.com/apache/arrow-site/pull/587#issuecomment-2650587427
This seems to work now:
https://bsky.app/profile/arrow.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #587:
URL: https://github.com/apache/arrow-site/pull/587#discussion_r1950614736
##########
_config.yml:
##########
@@ -25,6 +25,7 @@ kramdown:
include:
- _static
+ - .well-known
Review Comment:
If this has been tested and works, I agree, this sounds like a better solution than manually `cp` files. We probably want to have a single way of doing this for the other files we are copying.
Thanks for finding out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #587:
URL: https://github.com/apache/arrow-site/pull/587#discussion_r1951567704
##########
_config.yml:
##########
@@ -25,6 +25,7 @@ kramdown:
include:
- _static
+ - .well-known
Review Comment:
Ah, we should use `include` instead of raw `cp` for them too.
Sorry, I didn't notice this approach when I did it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #587:
URL: https://github.com/apache/arrow-site/pull/587#discussion_r1950592304
##########
_config.yml:
##########
@@ -25,6 +25,7 @@ kramdown:
include:
- _static
+ - .well-known
Review Comment:
To be honest I am not sure what this include does but I think we should just copy the file on the deploy step:
https://github.com/apache/arrow-site/blob/aaa5896d63ca53208a098ff32d448afffe5c2c73/.github/workflows/deploy.yml#L80-L81
From the comments on this PR, I think this is where we copy it:
https://github.com/apache/arrow-site/pull/506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add ATProtocol handle resolution file [arrow-site]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #587:
URL: https://github.com/apache/arrow-site/pull/587#issuecomment-2650627611
One button still needed to be pressed, but now the handle is updated as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org