You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/14 04:13:47 UTC

[GitHub] [apisix] tzssangglass opened a new pull request, #6842: fix(grpc-web): don't override Access-Control-Allow-Origin header in r…

tzssangglass opened a new pull request, #6842:
URL: https://github.com/apache/apisix/pull/6842

   …esponse
   
   Closes #6834
   
   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes # (issue)
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tzssangglass commented on pull request #6842: fix(grpc-web): don't override Access-Control-Allow-Origin header in response

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on PR #6842:
URL: https://github.com/apache/apisix/pull/6842#issuecomment-1099775313

   > I think we should also respect and don't override all CORS headers in the grpc-web plugin if already set by the CORS plugin
   
   yes, this is how this PR is handled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] HalilOzkan commented on pull request #6842: fix(grpc-web): don't override Access-Control-Allow-Origin header in response

Posted by GitBox <gi...@apache.org>.
HalilOzkan commented on PR #6842:
URL: https://github.com/apache/apisix/pull/6842#issuecomment-1099082550

   I think we should also respect and don't override all CORS headers in the grpc-web plugin if already set by the CORS plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #6842: fix(grpc-web): don't override Access-Control-Allow-Origin header in response

Posted by GitBox <gi...@apache.org>.
spacewander merged PR #6842:
URL: https://github.com/apache/apisix/pull/6842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org