You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/04/13 19:46:55 UTC

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7324: Honor spark case sensitivity in ALTER TABLE.. ORDERED BY

aokolnychyi commented on code in PR #7324:
URL: https://github.com/apache/iceberg/pull/7324#discussion_r1165960760


##########
api/src/main/java/org/apache/iceberg/SortOrderBuilder.java:
##########
@@ -103,4 +103,12 @@ default R desc(Term term) {
    * @return this for method chaining
    */
   R desc(Term term, NullOrder nullOrder);
+
+  /**
+   * Set case sensitivity of sort column name resolution.
+   *
+   * @param caseSensitive when true, column name resolution is case-sensitive
+   * @return this for method chaining
+   */
+  R caseSensitive(boolean caseSensitive);

Review Comment:
   What about throwing `UnsupportedOperationException` instead of changing API checks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org