[GitHub] [maven-resolver] slawekjaranowski commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180727977


##########
pom.xml:
##########
@@ -93,7 +93,8 @@
     <guavaVersion>30.1-jre</guavaVersion>
     <guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
     <slf4jVersion>1.7.36</slf4jVersion>
-    <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+    <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
+    <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>

Review Comment:
   Here can also be simple `1.8.0-362`



##########
pom.xml:
##########
@@ -93,7 +93,8 @@
     <guavaVersion>30.1-jre</guavaVersion>
     <guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
     <slf4jVersion>1.7.36</slf4jVersion>
-    <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+    <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>

Review Comment:
   It is exactly the same - what is the reason for such change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org