[GitHub] dongjoon-hyun commented on a change in pull request #23652: [SPARK-26718][SS][BRANCH-2.4] Fixed integer overflow in SS kafka rateLimit calculation

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23652: [SPARK-26718][SS][BRANCH-2.4] Fixed integer overflow in SS kafka rateLimit calculation
URL: https://github.com/apache/spark/pull/23652#discussion_r251988565
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
 ##########
 @@ -188,9 +188,15 @@ private[kafka010] class KafkaSource(
           tp -> sizes.get(tp).map { size =>
             val begin = from.get(tp).getOrElse(fromNew(tp))
             val prorate = limit * (size / total)
-            logDebug(s"rateLimit $tp prorated amount is $prorate")
-            // Don't completely starve small topicpartitions
 
 Review comment:
   In the master, we didn't touch line 191 and 192.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org