You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Hastyshell (via GitHub)" <gi...@apache.org> on 2026/04/02 04:24:18 UTC

[PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Hastyshell opened a new pull request, #62034:
URL: https://github.com/apache/doris/pull/62034

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "Hastyshell (via GitHub)" <gi...@apache.org>.
Hastyshell commented on PR #62034:
URL: https://github.com/apache/doris/pull/62034#issuecomment-4174629432

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #62034:
URL: https://github.com/apache/doris/pull/62034#issuecomment-4174731563

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29297 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit abd42189de6ded73cbc5f040be42c0fa89f3186e, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17588	3752	3671	3671
   q2	q3	10671	863	606	606
   q4	4676	463	358	358
   q5	7449	1326	1155	1155
   q6	189	167	137	137
   q7	914	963	780	780
   q8	9319	1430	1325	1325
   q9	5439	5294	5255	5255
   q10	6266	2004	1741	1741
   q11	476	280	291	280
   q12	889	693	508	508
   q13	18045	2797	2172	2172
   q14	281	283	256	256
   q15	q16	862	837	781	781
   q17	1068	1138	803	803
   q18	6488	5728	5612	5612
   q19	1184	1104	1095	1095
   q20	605	537	413	413
   q21	4833	2481	2023	2023
   q22	508	408	326	326
   Total cold run time: 97750 ms
   Total hot run time: 29297 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4593	4534	4583	4534
   q2	q3	4630	4782	4180	4180
   q4	2114	2178	1383	1383
   q5	4924	5003	5203	5003
   q6	188	163	131	131
   q7	2024	1755	1625	1625
   q8	3293	3113	3080	3080
   q9	8293	8224	8507	8224
   q10	4511	4592	4274	4274
   q11	584	400	380	380
   q12	658	708	482	482
   q13	2728	3033	2354	2354
   q14	300	294	260	260
   q15	q16	740	792	694	694
   q17	1343	1384	1222	1222
   q18	7884	7027	7038	7027
   q19	1136	1116	1126	1116
   q20	2200	2196	1955	1955
   q21	6057	5350	4884	4884
   q22	529	501	406	406
   Total cold run time: 58729 ms
   Total hot run time: 53214 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #62034:
URL: https://github.com/apache/doris/pull/62034#issuecomment-4174770517

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 179998 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit abd42189de6ded73cbc5f040be42c0fa89f3186e, data reload: false
   
   query5	4332	648	516	516
   query6	325	234	219	219
   query7	4235	590	328	328
   query8	329	244	227	227
   query9	8739	3864	3877	3864
   query10	499	387	344	344
   query11	6694	5467	5119	5119
   query12	182	134	127	127
   query13	1298	599	447	447
   query14	5712	5185	4792	4792
   query14_1	4137	4137	4095	4095
   query15	218	202	180	180
   query16	1041	463	403	403
   query17	1148	768	678	678
   query18	2722	534	390	390
   query19	258	232	199	199
   query20	144	133	128	128
   query21	228	146	151	146
   query22	13936	14882	14393	14393
   query23	18379	17160	16652	16652
   query23_1	16830	16671	16647	16647
   query24	7428	1720	1326	1326
   query24_1	1344	1355	1340	1340
   query25	570	485	438	438
   query26	1253	311	172	172
   query27	2695	603	364	364
   query28	4401	1933	1885	1885
   query29	960	661	563	563
   query30	301	220	230	220
   query31	1097	1029	946	946
   query32	81	71	70	70
   query33	543	344	286	286
   query34	1178	1123	690	690
   query35	745	819	649	649
   query36	1243	1242	1087	1087
   query37	158	97	84	84
   query38	3080	3052	2953	2953
   query39	908	898	852	852
   query39_1	833	839	837	837
   query40	237	153	136	136
   query41	62	59	58	58
   query42	277	267	270	267
   query43	316	318	273	273
   query44	
   query45	203	195	194	194
   query46	1170	1197	772	772
   query47	2349	2305	2232	2232
   query48	415	417	293	293
   query49	631	535	423	423
   query50	710	289	213	213
   query51	4276	4306	4223	4223
   query52	278	279	274	274
   query53	318	343	269	269
   query54	316	277	269	269
   query55	96	94	89	89
   query56	333	322	313	313
   query57	1662	1700	1666	1666
   query58	299	274	276	274
   query59	2881	2969	2745	2745
   query60	338	370	327	327
   query61	161	160	160	160
   query62	689	619	560	560
   query63	309	269	272	269
   query64	5373	1444	1106	1106
   query65	
   query66	1417	484	364	364
   query67	24443	24365	24160	24160
   query68	
   query69	449	345	311	311
   query70	990	1041	1008	1008
   query71	365	328	313	313
   query72	3051	2767	2623	2623
   query73	837	796	479	479
   query74	9867	9707	9624	9624
   query75	3585	3388	3024	3024
   query76	2344	1132	790	790
   query77	405	416	345	345
   query78	11262	11330	10754	10754
   query79	1476	1143	852	852
   query80	872	791	702	702
   query81	455	289	238	238
   query82	738	161	126	126
   query83	381	309	272	272
   query84	279	153	119	119
   query85	1007	595	457	457
   query86	394	348	336	336
   query87	3244	3216	3056	3056
   query88	3536	2672	2681	2672
   query89	473	428	378	378
   query90	1931	184	178	178
   query91	184	176	162	162
   query92	84	71	71	71
   query93	901	866	524	524
   query94	535	334	305	305
   query95	672	473	337	337
   query96	1014	813	312	312
   query97	2687	2704	2550	2550
   query98	243	237	230	230
   query99	1066	1065	952	952
   Total cold run time: 258341 ms
   Total hot run time: 179998 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62034:
URL: https://github.com/apache/doris/pull/62034#issuecomment-4174921226

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/abd42189de6ded73cbc5f040be42c0fa89f3186e_abd42189de6ded73cbc5f040be42c0fa89f3186e/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/abd42189de6ded73cbc5f040be42c0fa89f3186e_abd42189de6ded73cbc5f040be42c0fa89f3186e/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.89% (20030/37869) |
   | Line Coverage     | 36.48% (187970/515229) |
   | Region Coverage   | 32.69% (145665/445620) |
   | Branch Coverage   | 33.89% (63874/188462) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62034:
URL: https://github.com/apache/doris/pull/62034#issuecomment-4174548014

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path [doris]

Posted by "Hastyshell (via GitHub)" <gi...@apache.org>.
Hastyshell closed pull request #62034: [fix](delete-pred) normalize DeleteSubPredicatePB operator on read path
URL: https://github.com/apache/doris/pull/62034


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org