You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/11/21 01:14:47 UTC

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16761


Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................

IMPALA-9050: fix TestScanRangeLengths params

This test is only relevant from HDFS-based table formats. The option
under test does not affect behaviour for Kudu or HBase.

Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/16761/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Nov 2020 18:46:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Nov 2020 18:46:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6699/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Nov 2020 18:46:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................

IMPALA-9050: fix TestScanRangeLengths params

This test is only relevant from HDFS-based table formats. The option
under test does not affect behaviour for Kudu or HBase.

Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Reviewed-on: http://gerrit.cloudera.org:8080/16761
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7708/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 Nov 2020 01:29:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16761 )

Change subject: IMPALA-9050: fix TestScanRangeLengths params
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8591335dcdc85ce27674b35661444a46d30d5a
Gerrit-Change-Number: 16761
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Nov 2020 00:11:23 +0000
Gerrit-HasComments: No