You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2024/12/19 00:02:01 UTC
[PR] Deprecate MapWriter.append [solr]
dsmiley opened a new pull request, #2919:
URL: https://github.com/apache/solr/pull/2919
I don't really like MapWriter.append – undocumented and called in only 2 places. Since MapWriter is implemented by a great many things, we should be conservative adding methods there. append() is kind of clever but I think it's outside the scope of what MapWriter should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1892383853
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
I kind of wish we always provide a bit more detail on these `@Deprecate` tags. I like when I see a "since" as it let's me know when the code can be deleted. I like when there is a "use X instead" comment.
I did a pass the other week around deprecated code and a lot it wasn't clear what would trigger the deleting of it.. Or how long it had been deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2919:
URL: https://github.com/apache/solr/pull/2919#issuecomment-2555703092
I'm thinking of merging this with removal of the deprecated method, and in 9x & branch_9_8 simply deprecating the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1892659835
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
for an obscure method; I think we shouldn't burden ourselves with overly helping likely non-existent users of such. Personally I do plenty of code sleuthing to identify when lines of code are added/removed like a Deprecate or whatever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1896037341
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
I was looking at code in 10 that was marked deprecated so I could remove it. I'd love to see a release of 10 that has NO deprecation tags in it, which may be a pipe dream... I was hoping to see some indication that would tell me what methods to be used in place for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2919:
URL: https://github.com/apache/solr/pull/2919#issuecomment-2564312816
I think I can better articulate my original question. Now that `MapWriter.append()` is deprecated on 9x, can we remove it from 10x? I like that `TestLegacyCircuitBreaker` has a lot of direction for future Solr developers...:
```
/**
* Tests the original circuit breaker configuration format, which was not configurable.
*
* @deprecated Remove in 10.0
*/
@Deprecated(since = "9.4")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #2919:
URL: https://github.com/apache/solr/pull/2919#discussion_r1894685936
##########
solr/solrj/src/java/org/apache/solr/common/MapWriter.java:
##########
@@ -70,8 +74,7 @@ public MapWriter.EntryWriter put(CharSequence k, Object v) {
writer.endObject();
}
- void writeMap(EntryWriter ew) throws IOException;
-
+ @Deprecated
Review Comment:
> I did a pass the other week around deprecated code and a lot it wasn't clear what would trigger the deleting of it.. Or how long it had been deprecated.
Curious; in that instance, why did you care? In this case, it's just some small utility method that any caller can do themselves. Thus the deprecation rationale is not something I think any user would find interesting _for this method_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #2919:
URL: https://github.com/apache/solr/pull/2919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Deprecate MapWriter.append [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2919:
URL: https://github.com/apache/solr/pull/2919#issuecomment-2568273954
Yes; anything deprecated in 9x is removable in 10x.
That's a general statement, and it applies here too. I know we sometimes deprecate things that are still used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org