You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/10 20:30:49 UTC

Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35305/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Bugs: MESOS-2818
    https://issues.apache.org/jira/browse/MESOS-2818


Repository: mesos


Description
-------

Added a SlaveTest to caputure the case when containerizer usage fails.


Diffs
-----

  src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 

Diff: https://reviews.apache.org/r/35305/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35305/#review87443
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35259, 35260, 35264, 35305]

All tests passed.

- Mesos ReviewBot


On June 10, 2015, 6:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35305/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
>     https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a SlaveTest to caputure the case when containerizer usage fails.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 
> 
> Diff: https://reviews.apache.org/r/35305/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 35305: Added a SlaveTest to caputure the case when containerizer usage fails.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35305/#review87501
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On June 10, 2015, 6:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35305/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
>     https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a SlaveTest to caputure the case when containerizer usage fails.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 
> 
> Diff: https://reviews.apache.org/r/35305/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>