[GitHub] metron pull request #749: METRON-1176 Rest support for setting permissions o...

[ottobackwards <gi...@git.apache.org>]

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/749

    METRON-1176 Rest support for setting permissions on files written by HdfsService

    This PR adds support to the HdfsController and HdfsService to optional set the permissions on files written to hdfs.
    
    Three new parameters, one each for user, group, and other mode are passed, in the form of symbolic permission strings ('rwx','r-x','r--').
    
    If **any** of the three are missing, no permission override will be executed.
    If **any** of the three are not valid, and exception will be thrown.
    
    ##Testing
    [ ] Build, tests should run
    [ ] Full Dev, Swagger, use the HdfsController post, and set the permissions, don't set the permissions, set invalid permissions
    [ ] Verify files, for example a good place to write to is "/apps/metron/patterns/NAME"
    [ ] In the metron ui, testing grok patterns should work
    
    ```bash
    > vagrant ssh
    > sudo su -
    > hdfs dfs -ls /apps/metron/patterns
    
    ```
    
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    - [na] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [na] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron hdfs_permissions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #749
    
----
commit a0f1b10f5e3f11c3824fa47bfedc3995e45c302d
Author: Otto Fowler <ot...@gmail.com>
Date:   2017-09-11T19:30:35Z

    Refactor the hdfs rest endpoint to support writing with permissions.
    permissions are passes as three strings ( not required ) that represent
    symbolic permsions see FsAction.
    For example "rw-", "rwx", "r-x"

commit d2d76aca88a4f34d4ff31fa4446400ecb2be3613
Author: Otto Fowler <ot...@gmail.com>
Date:   2017-09-12T02:34:13Z

    readme update

----


---

[GitHub] metron issue #749: METRON-1176 Rest support for setting permissions on files...

[merrimanr <gi...@git.apache.org>]

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/749
  
    I spun this up in full dev and it worked as expected.  Thanks for the contribution.  +1


---

[GitHub] metron pull request #749: METRON-1176 Rest support for setting permissions o...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/749


---