You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/27 02:46:42 UTC

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #5327: create RANGE sharding algorithm

tristaZero edited a comment on pull request #5327:
URL: https://github.com/apache/shardingsphere/pull/5327#issuecomment-619679212


   @strongduanmu 
   
   Hi, I am glad to read your organized and straightforward code. :)
   There is my concern about `range.partition.split.value` which is the key point of this algorithm.
   
   Users need to list all endpoints of each range partitions, i.e, 10,20,30,40...
   Besides, it generates complicated code handling. Do you think it is better to prefer the partition volume than listing all endpoints? That is, in this case: instead of `range.partition.split.value=10,20,30,40`, maybe we can consider `partition.volume = 10`. I am not sure, so I'd like to listen to your voice. 😀 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org