You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/04 06:50:33 UTC

[GitHub] [spark] sigmod commented on a change in pull request #32421: [SPARK-35294][SQL] Add tree traversal pruning in rules with dedicated files under optimizer

sigmod commented on a change in pull request #32421:
URL: https://github.com/apache/spark/pull/32421#discussion_r625544743



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala
##########
@@ -93,4 +94,12 @@ case class LocalRelation(
   }
 
   override def maxRows: Option[Long] = Some(data.length.toLong)
+
+  override val nodePatterns: Seq[TreePattern] = {
+    if (this.data.isEmpty) {

Review comment:
       Done. 
   Thanks, Gengliang! Make sense!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org