You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/02/18 00:52:54 UTC

[GitHub] [groovy] paulk-asert commented on pull request #1492: GROOVY-9946: Add `@Pure` to mark constant result of method

paulk-asert commented on pull request #1492:
URL: https://github.com/apache/groovy/pull/1492#issuecomment-780954105


   LGTM. The one thing which I think we should do is move the `@Pure` marker interface into a groovy.annotations package in its own groovy-annotations mandatory module. However, I can do that move later if you like. That would be a good place for other such marker interfaces to also go. Then folks writing Java libraries could make them more Groovy friendly in some places and only need worry about having that one module available as a compile-time only dependency for their builds.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org