You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/25 13:47:04 UTC

[GitHub] [commons-lang] HubertWo opened a new pull request #634: NumberUtilsTest - fixed types in min/max tests

HubertWo opened a new pull request #634:
URL: https://github.com/apache/commons-lang/pull/634


   Some of the tests related to finding min and max values does not have types declared. As a result min/max of value ```int``` methods are being tested multiple times without invoking target methods ```byte```, ```long``` etc.
   I fixed types and added casting where required.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] HubertWo commented on a change in pull request #634: NumberUtilsTest - incorrect types in min/max tests

Posted by GitBox <gi...@apache.org>.
HubertWo commented on a change in pull request #634:
URL: https://github.com/apache/commons-lang/pull/634#discussion_r511601507



##########
File path: src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
##########
@@ -16,20 +16,15 @@
  */
 package org.apache.commons.lang3.math;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Test;
 
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Modifier;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.math.RoundingMode;
 
-import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;

Review comment:
       Fixed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #634: NumberUtilsTest - incorrect types in min/max tests

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #634:
URL: https://github.com/apache/commons-lang/pull/634#issuecomment-716154231


   
   [![Coverage Status](https://coveralls.io/builds/34440090/badge)](https://coveralls.io/builds/34440090)
   
   Coverage increased (+0.2%) to 94.915% when pulling **d46f06e73ebf6cdb911855bbf1e6abcb8f9f1243 on HubertWo:numberUtilsTests** into **110b4c021e4901efab91499fedcdfb43c564ebdf on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on a change in pull request #634: NumberUtilsTest - incorrect types in min/max tests

Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #634:
URL: https://github.com/apache/commons-lang/pull/634#discussion_r511600890



##########
File path: src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
##########
@@ -16,20 +16,15 @@
  */
 package org.apache.commons.lang3.math;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import org.junit.jupiter.api.Test;
 
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Modifier;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.math.RoundingMode;
 
-import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;

Review comment:
       Please don't use star imports.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory merged pull request #634: NumberUtilsTest - incorrect types in min/max tests

Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #634:
URL: https://github.com/apache/commons-lang/pull/634


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org