You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/02/14 12:45:08 UTC
[PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
mdedetrich opened a new pull request, #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92
See https://github.com/sbt/sbt-paradox-material-theme/issues/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489440814
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
You mean the license itself or the license file (the license is still the same, there was no project relicensing)? The main reason for updating this is the repo location has changed (from https://github.com/jonas/paradox-material-theme to https://github.com/sbt/sbt-paradox-material-theme) and I am not sure how long github redirects are guaranteed for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489440814
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
You mean the license itself or the license file? The main reason for updating this is the repo location has changed and I am not sure how long I can guarantee github redirects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1490101371
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
@pjfanning Done, I checked and it lgtm but ill wait for your review just to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1490098602
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
Sure, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489440814
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
You mean the license itself or the license file (the license is still the same, there was no project relicensing)? The main reason for updating this is the repo location has changed (from https://github.com/jonas/paradox-material-theme to https://github.com/sbt/sbt-paradox-material-theme) and I am not sure how long I can guarantee github redirects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489446818
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
ok - since the repo has moved - then we can change the links
Can we change the version back though?
```
pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0
```
We adapted this code before 0.7.0 was released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489440814
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
You mean the license itself or the license file? The main reason for updating this is the repo location has changed (from https://github.com/jonas/paradox-material-theme to https://github.com/sbt/sbt-paradox-material-theme) and I am not sure how long I can guarantee github redirects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92#discussion_r1489436223
##########
LICENSE:
##########
@@ -202,8 +202,8 @@
---------------
-pekko-sbt-paradox contains scripting adapted from paradox-material-theme version 0.6.0,
-which was released under an MIT license <https://github.com/jonas/paradox-material-theme>.
+pekko-sbt-paradox contains scripting adapted from sbt-paradox-material-theme version 0.7.0,
Review Comment:
I would prefer not to change the license - the original text is more accurate because that is where we borrowed the code from. Likewise for the links in the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-paradox-material-theme 0.7.0 [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #92:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org