You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2017/07/04 13:13:01 UTC
[jira] [Commented] (FLINK-7100) TaskManager metrics are registered
twice
[ https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073646#comment-16073646 ]
Chesnay Schepler commented on FLINK-7100:
-----------------------------------------
We should also de-duplicate the {{MetricUtils}} and {{TaskExecutorMetricsInitializer}} classes. If we keep the latter we should obviously rename it.
> TaskManager metrics are registered twice
> ----------------------------------------
>
> Key: FLINK-7100
> URL: https://issues.apache.org/jira/browse/FLINK-7100
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime, Metrics
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Fix For: 1.4.0, 1.3.2
>
>
> TaskManager metrics are currently registered twice, once when the TaskManager is started and once when the TaskManager associates with a JobManager.
> Originally the metrics were registered when the TM associates with the JM and unregistered upon disassociation.
> 9e9776f17ed18b12af177e31ab0bc266236f85ef modified the {{TaskManager}} to use the {{TaskManagerServices}}, which when loaded _also_ register the metrics.
> I suggest to remove the registrations that happen upon (dis-)association.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)