[GitHub] [superset] suddjian commented on a change in pull request #15005: fix(native-filters): show error if default value query failed

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15005:
URL: https://github.com/apache/superset/pull/15005#discussion_r648732947



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -345,36 +347,45 @@ const FiltersConfigForm = (
       defaultValueQueriesData: null,
       isDataDirty: false,
     });
+    setError('');

Review comment:
       Might be cleaner to make a wrapper function `setFilterQueryResult` that calls both `setNativeFilterFieldValues` and `setError` since they are always called together.
   
   As well as setting the value to null when there is an error maybe?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org