You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/15 07:38:11 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #681: Integration test for controller connect and disconnect

jiajunwang commented on a change in pull request #681: Integration test for controller connect and disconnect
URL: https://github.com/apache/helix/pull/681#discussion_r366726782
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/HelixTimerTask.java
 ##########
 @@ -32,4 +32,9 @@
    * Stop a timer task
    */
   public abstract void stop();
+
+  /**
+   * Validate if the timer task is stopped
+   */
+  public abstract boolean isStopped();
 
 Review comment:
   If this is for test only, please keep it in the implementation classes and keep it protected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org