You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/07/07 15:35:26 UTC
[GitHub] [arrow] pitrou opened a new pull request, #36557: MINOR: [C++][CI] Bump AWS SDK version
pitrou opened a new pull request, #36557:
URL: https://github.com/apache/arrow/pull/36557
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1626907116
We should probably bump the bundled version (in versions.txt) but that might be an order of magnitude more difficult if some adjustements in the build chain are needed :-) I'll let you @kou decide on that.
That said, I also think there's value in exercising several versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] h-vetinari commented on pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "h-vetinari (via GitHub)" <gi...@apache.org>.
h-vetinari commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1628738974
We've had issues with migrating aws-sdk-cpp because there have been _so many versions_, see https://github.com/conda-forge/aws-sdk-cpp-feedstock/issues/662 (aside from the long-standing issue that prevented arrow from moving to 1.9).
We've been keeping the aws builds up-to-date, but haven't started a migration for a while. We could easily move to 1.11 though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1625701903
@github-actions crossbow submit test-conda*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1625706773
Also @h-vetinari FYI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1625596570
Revision: f87643c4e7fb4162482208c80a1b6e7ecb8753ba
Submitted crossbow builds: [ursacomputing/crossbow @ actions-181c789933](https://github.com/ursacomputing/crossbow/branches/all?query=actions-181c789933)
|Task|Status|
|----|------|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5488123075/jobs/10000520140)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14863151942)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/5488124331/jobs/10000523339)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5488124791/jobs/10000524546)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/5488126089/jobs/10000527506)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488123321/jobs/10000520808)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/5488125828/jobs/10000526761)|
|test-conda-python-3.10-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/5488127726/jobs/10000530991)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/5488124551/jobs/10000523906)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/5488123586/jobs/10000521372)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488122764/jobs/10000519450)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5488126619/jobs/10000528545)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/5488124985/jobs/10000525021)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5488125516/jobs/10000526095)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/5488127115/jobs/10000529792)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5488123882/jobs/10000522261)|
|test-conda-python-3.8-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5488122313/jobs/10000518690)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/5488126825/jobs/10000529197)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488125202/jobs/10000525547)|
|test-conda-python-3.9-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5488124018/jobs/10000522603)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1627656013
> We may want to unpin later because `libarrow` conda package doesn't pin `aws-sdk-cpp`: https://github.com/conda-forge/arrow-cpp-feedstock/blob/main/recipe/meta.yaml#L110 Our releases should work with the latest conda `aws-sdk-cpp` version.
Unpinning would make CI much more fragile because there are now versions of `aws-sdk-cpp` quite frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1625705057
Revision: 1082039b199761f8af3ea4afd64baaf5b59f28dd
Submitted crossbow builds: [ursacomputing/crossbow @ actions-891c1e1fcf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-891c1e1fcf)
|Task|Status|
|----|------|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/5488858123/jobs/10002273827)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/14865414247)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/5488855347/jobs/10002267908)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5488855888/jobs/10002268962)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/5488855626/jobs/10002268435)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488857332/jobs/10002271953)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/5488858992/jobs/10002276094)|
|test-conda-python-3.10-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/5488858685/jobs/10002275338)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/5488856122/jobs/10002269465)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/5488858506/jobs/10002274846)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488856615/jobs/10002270522)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5488857507/jobs/10002272344)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/5488856840/jobs/10002271081)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/5488854517/jobs/10002266488)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/5488855085/jobs/10002267421)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5488858323/jobs/10002274276)|
|test-conda-python-3.8-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions/runs/5488856451/jobs/10002270165)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/5488857899/jobs/10002273307)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/5488854743/jobs/10002266828)|
|test-conda-python-3.9-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions/runs/5488857697/jobs/10002272869)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #36557:
URL: https://github.com/apache/arrow/pull/36557#discussion_r1256148822
##########
ci/conda_env_cpp.txt:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-aws-sdk-cpp=1.10.13
+aws-sdk-cpp
Review Comment:
```suggestion
aws-sdk-cpp=1.11.68
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1646154762
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit a8660e045b4bdd47c1be851fa024dfc259c968a6.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15245704832) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36557:
URL: https://github.com/apache/arrow/pull/36557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #36557: MINOR: [C++][CI] Bump conda-forge AWS SDK version
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1626219492
Should we not pin the same version that is used in versions.txt or the inverse also bump the versions.txt version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36557: MINOR: [C++][CI] Bump AWS SDK version
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36557:
URL: https://github.com/apache/arrow/pull/36557#issuecomment-1625592782
@github-actions crossbow submit test-conda*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org