You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2026/03/23 07:32:04 UTC
[PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
vishesh92 opened a new pull request, #12874:
URL: https://github.com/apache/cloudstack/pull/12874
### Description
This PR fixes the registration of existing Cross Zone templates for Edge Zone.
This PR also offloads the filtering of cross zones to the database.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4153902715
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4153001303
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6361599414
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4284782632
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
what happens to edge zones created before this fix? looks like they only pick up cross zone templates when the zone is created, so theirs stay missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti merged PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4119619379
<b>[SF] Trillian Build Failed (tid-15725)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4109408020
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4358590770
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
@DaanHoogland @Damans227 @sureshanaparti should I add this query as part of the upgrade migration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6367436636
@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4108628954
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4154266189
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-5811278158
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6290414318
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4357940244
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
the existing templates stay broken on existing zones after this change as well. we need to run the below SQL for fixing (need to verify once)
```sql
INSERT INTO cloud.template_zone_ref (zone_id, template_id, created, last_updated)
SELECT dc.id, vt.id, NOW(), NOW()
FROM cloud.data_center dc
JOIN cloud.vm_template vt ON vt.cross_zones = 1 AND vt.removed IS NULL
WHERE dc.type = 'Edge' AND dc.removed IS NULL
AND NOT EXISTS (SELECT 1 FROM cloud.template_zone_ref tzr
WHERE tzr.zone_id = dc.id AND tzr.template_id = vt.id AND tzr.removed IS NULL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4152690510
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4108712189
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12874?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.70%. Comparing base ([`e93ae1a`](https://app.codecov.io/gh/apache/cloudstack/commit/e93ae1a4f455a0dff010db673b47b913220f9037?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b2950d7`](https://app.codecov.io/gh/apache/cloudstack/commit/b2950d7ae43711992dd3549b32f575e75097397f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (e93ae1a) and HEAD (b2950d7). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (e93ae1a) | HEAD (b2950d7) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.22 #12874 +/- ##
=============================================
- Coverage 17.61% 3.70% -13.91%
=============================================
Files 5917 448 -5469
Lines 531430 38028 -493402
Branches 64973 7036 -57937
=============================================
- Hits 93586 1409 -92177
+ Misses 427288 36432 -390856
+ Partials 10556 187 -10369
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12874/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12874/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.70% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12874/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12874?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4357980665
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
so you will add this to an upgrade path, @vishesh92 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6361634315
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6408346179
<b>[SF] Trillian test result (tid-17248)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51985 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12874-t17248-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r2973511900
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrosszoneTemplatesToZone(zone.getId());
Review Comment:
```suggestion
_templateService.associateCrossZoneTemplatesToZone(zone.getId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4131362299
<b>[SF] Trillian test result (tid-15728)</b>
Environment: kvm-ol9 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 57991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12874-t15728-kvm-ol9.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 50.50 | test_network.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6365214321
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6365267705
<b>[SF] Trillian Build Failed (tid-17229)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6398096648
@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r3008226929
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/resource/SimulatorDiscoverer.java:
##########
@@ -20,8 +20,10 @@
import java.net.URLDecoder;
import java.util.Date;
import java.util.HashMap;
+import java.util.HashSet;
Review Comment:
SimulatorDiscoverer no longer uses java.util.Date after switching to TemplateService-based association, but the Date import remains. Unused imports are compilation errors in Java; please remove this import (and any other now-unused imports introduced by this refactor).
```suggestion
import java.util.HashMap;
```
##########
plugins/hypervisors/simulator/src/main/java/com/cloud/resource/SimulatorDiscoverer.java:
##########
@@ -50,6 +52,7 @@
import com.cloud.storage.VMTemplateZoneVO;
import com.cloud.storage.dao.VMTemplateDao;
import com.cloud.storage.dao.VMTemplateZoneDao;
+import org.apache.cloudstack.engine.subsystem.api.storage.TemplateService;
Review Comment:
After refactoring to call TemplateService in postDiscovery, the VMTemplate* imports are no longer used in this class. These unused imports will fail compilation; remove them (and consider dropping the corresponding unused injected fields as well).
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -4232,7 +4232,6 @@ private void duplicateCacheStoreRecordsToRegionStore(long storeId) {
private void associateCrosszoneTemplatesToZone(Long zoneId) {
VMTemplateZoneVO tmpltZone;
Review Comment:
This helper is still named `associateCrosszoneTemplatesToZone` while the TemplateService API and most call sites now use `associateCrossZoneTemplatesToZone`. Renaming this private method (and its call at StorageManagerImpl.java:4004) would keep naming consistent and make grepping for the behavior easier.
```suggestion
```
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java:
##########
@@ -285,23 +290,24 @@ public void postDiscovery(List<HostVO> hosts, long msId) {
_agentMgr.agentStatusTransitTo(h, Event.AgentDisconnected, msId);
}
}
+ Set<Long> dcIds = new HashSet<>();
for (HostVO h : hosts) {
- associateTemplatesToZone(h.getId(), h.getDataCenterId());
+ dcIds.add(h.getDataCenterId());
+ }
+ for (Long dcId : dcIds) {
+ templateService.associateCrossZoneTemplatesToZone(dcId);
}
-
}
private void associateTemplatesToZone(long hostId, long dcId) {
VMTemplateZoneVO tmpltZone;
- List<VMTemplateVO> allTemplates = _vmTemplateDao.listAll();
- for (VMTemplateVO vt : allTemplates) {
- if (vt.isCrossZones()) {
- tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId());
- if (tmpltZone == null) {
- VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date());
- _vmTemplateZoneDao.persist(vmTemplateZone);
- }
+ List<VMTemplateVO> crossZoneTemplates = _vmTemplateDao.listAllCrossZoneTemplates();
+ for (VMTemplateVO vt : crossZoneTemplates) {
+ tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId());
+ if (tmpltZone == null) {
+ VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date());
+ _vmTemplateZoneDao.persist(vmTemplateZone);
}
}
}
Review Comment:
postDiscovery now delegates cross-zone association to TemplateService, but the private associateTemplatesToZone(...) helper remains and is no longer called (and its hostId parameter is unused). Removing this unused method (and the now-redundant VMTemplate* DAO dependencies it exists solely to support) will reduce dead code and avoid maintaining two association paths.
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -4232,7 +4232,6 @@ private void duplicateCacheStoreRecordsToRegionStore(long storeId) {
private void associateCrosszoneTemplatesToZone(Long zoneId) {
VMTemplateZoneVO tmpltZone;
Review Comment:
associateCrosszoneTemplatesToZone now just delegates to _imageSrv.associateCrossZoneTemplatesToZone, so the local variable `tmpltZone` is no longer used. Please remove the unused variable to keep the method clean (and avoid IDE/compiler warnings).
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-5812728065
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6387223840
<b>[SF] Trillian test result (tid-17233)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 92048 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12874-t17233-kvm-ol8.zip
Smoke tests completed. 133 look OK, 16 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_CRUD_operations_userdata | `Error` | 1519.11 | test_register_userdata.py
test_deploy_vm_with_registered_userdata | `Error` | 3.49 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 3.48 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 3.38 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 3.54 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 3.61 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 3.65 | test_register_userdata.py
test_user_userdata_crud | `Error` | 3.59 | test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
test_03_register_template | `Error` | 1.14 | test_resource_names.py
ContextSuite context=TestRestoreVM>:setup | `Error` | 0.00 | test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.32 | test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSslOffloading>:setup | `Error` | 0.00 | test_ssl_offloading.py
test_03_ssvm_internals | `Failure` | 12.99 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4359042524
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
it seems to be valid, but we'll need it for both upgrade paths:
4.22.1 -> 4.22.2 -> 24 and
4.22.1 -> 4.23 -> 24!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4359357728
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
I added here for 4.22.1 -> 4.22.2. Executing this again shouldn't cause any issues. I will create a separate PR for 4.23 -> 24!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r2973511900
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrosszoneTemplatesToZone(zone.getId());
Review Comment:
```suggestion
_templateService.associateCrossZoneTemplatesToZone(zone.getId());
```
update the actual method name & its references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4109416335
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4119220567
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4119205291
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-5618140743
one more round of smoke tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6398078296
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4108573528
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4109762832
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4152682091
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4153898144
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6366727269
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6365235191
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-4108575273
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r2990019221
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##########
@@ -881,17 +881,15 @@ public void associateTemplateToZone(long templateId, Long zoneId) {
// update template_zone_ref for cross-zone template for newly added zone
@Override
- public void associateCrosszoneTemplatesToZone(long dcId) {
+ public void associateCrossZoneTemplatesToZone(long dcId) {
VMTemplateZoneVO tmpltZone;
- List<VMTemplateVO> allTemplates = _templateDao.listAll();
- for (VMTemplateVO vt : allTemplates) {
- if (vt.isCrossZones()) {
- tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId());
- if (tmpltZone == null) {
- VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date());
- _vmTemplateZoneDao.persist(vmTemplateZone);
- }
+ List<VMTemplateVO> crossZoneTemplates = _templateDao.listAllCrossZoneTemplates();
+ for (VMTemplateVO vt : crossZoneTemplates) {
+ tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId());
+ if (tmpltZone == null) {
+ VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date());
+ _vmTemplateZoneDao.persist(vmTemplateZone);
Review Comment:
This is repeated in 3 other places - SimulatorDiscoverer, StorageManagerImpl and SecondaryStorageDiscoverer - can we find a way to extract this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6290379713
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6292108798
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✖️ suse15. SL-JID 19629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#discussion_r4357752869
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3157,6 +3160,12 @@ public DataCenterVO doInTransaction(final TransactionStatus status) {
// Create default system networks
createDefaultSystemNetworks(zone.getId());
+ // Associate cross zone templates with the Edge Zones here because they don't have SSVMs
+ // For Core zones, this happens when the SSVM starts up.
+ if (isEdge) {
+ _templateService.associateCrossZoneTemplatesToZone(zone.getId());
Review Comment:
@vishesh92 can you update on this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-6367414696
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Cross zone templates registration for Edge Zones [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12874:
URL: https://github.com/apache/cloudstack/pull/12874#issuecomment-5618131871
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org