You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nlpcraft.apache.org by ar...@apache.org on 2021/09/09 01:35:23 UTC
[incubator-nlpcraft] branch NLPCRAFT-431 updated: Code review.
This is an automated email from the ASF dual-hosted git repository.
aradzinski pushed a commit to branch NLPCRAFT-431
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git
The following commit(s) were added to refs/heads/NLPCRAFT-431 by this push:
new 2a38ea4 Code review.
2a38ea4 is described below
commit 2a38ea407fbb750609cfd116b4501fc4e8a17959
Author: Aaron Radzinski <ar...@datalingvo.com>
AuthorDate: Wed Sep 8 18:35:14 2021 -0700
Code review.
---
.../main/scala/org/apache/nlpcraft/model/NCModelView.java | 4 +++-
.../src/test/scala/org/apache/nlpcraft/NCTestElement.scala | 12 ++++++------
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModelView.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModelView.java
index 80cd161..30a2b40 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModelView.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/model/NCModelView.java
@@ -168,7 +168,9 @@ public interface NCModelView extends NCMetadata {
*/
boolean DFLT_IS_SPARSE = false;
- // TODO:
+ /**
+ * Default value for {@link #isGreedy()} method.
+ */
boolean DFLT_IS_GREEDY = true;
/**
diff --git a/nlpcraft/src/test/scala/org/apache/nlpcraft/NCTestElement.scala b/nlpcraft/src/test/scala/org/apache/nlpcraft/NCTestElement.scala
index 12bb325..daf1ab0 100644
--- a/nlpcraft/src/test/scala/org/apache/nlpcraft/NCTestElement.scala
+++ b/nlpcraft/src/test/scala/org/apache/nlpcraft/NCTestElement.scala
@@ -30,12 +30,12 @@ import scala.language.implicitConversions
case class NCTestElement(id: String, syns: String*) extends NCElement {
private val values = new util.ArrayList[NCValue]
- var metadata = super.getMetadata
- var description = super.getDescription
- var parentId = super.getParentId
- var permutateSynonyms = super.isPermutateSynonyms
- var sparse = super.isSparse
- var greedy = super.isGreedy
+ var metadata: util.Map[String, AnyRef] = super.getMetadata
+ var description: String = super.getDescription
+ var parentId: String = super.getParentId
+ var permutateSynonyms: Optional[lang.Boolean] = super.isPermutateSynonyms
+ var sparse: Optional[lang.Boolean] = super.isSparse
+ var greedy: Optional[lang.Boolean] = super.isGreedy
override def getId: String = id
override def getSynonyms: util.List[String] = (syns :+ id).asJava