You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2026/09/01 18:59:33 UTC
[PR] [SPARK-59158] Add docs, Helm chart, deployment examples, and Dockerfile [spark-connect-gateway]
viirya opened a new pull request, #16:
URL: https://github.com/apache/spark-connect-gateway/pull/16
### What changes were proposed in this pull request?
The **final PR** of the Spark Connect Gateway reference implementation import
(tracked in the do-not-merge reference PR #1). All Rust code has landed (15
crates, SPARK-58753 through SPARK-59145); this brings in everything that isn't
code:
- `Dockerfile` and `config.example.yaml`
- The full `README.md` (replacing the minimal bootstrap stub) and `ROADMAP.md`
- `docs/` — architecture, deployment, multitenancy, observability, perf-baseline,
runbook
- `deploy/helm/scg/` — the Helm chart (templates, values, chart README)
- `deploy/examples/` — end-to-end walkthroughs: smoke, multitenant,
multi-replica-redis, scale-test, kubeflow-spark-operator, trust-boundary,
auth-jwt, plus plain Spark Connect server manifests
- `test/integration/` — the Python client smoke test
No Rust code changes, so the workspace `members` list is untouched.
With this merged, the import is complete and the reference PR #1 can be closed.
### Why are the changes needed?
Implements the reference gateway from the approved SPIP (SPARK-58455), imported
one reviewable piece at a time. This completes the import.
### Does this PR introduce _any_ user-facing change?
No code change. It replaces the placeholder README with the real project README
and adds user-facing documentation, a Helm chart, and deployment examples.
### How was this patch tested?
`cargo fmt --all --check`, `cargo clippy --workspace --all-targets -- -D warnings`,
`cargo build --workspace`, and `cargo test --workspace` all still pass locally
(204 tests pass, 10 `#[ignore]`) — unaffected, since there are no Rust changes.
`helm lint deploy/helm/scg` passes. All relative links in README.md and docs/
were verified to resolve. Every file requiring an Apache license header has one;
`.md`/`.json`, Helm `NOTES.txt` and `.helmignore` are covered by the existing
licenserc ignore globs.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59158] Add docs, Helm chart, deployment examples, and Dockerfile [spark-connect-gateway]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #16: [SPARK-59158] Add docs, Helm chart, deployment examples, and Dockerfile
URL: https://github.com/apache/spark-connect-gateway/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59158] Add docs, Helm chart, deployment examples, and Dockerfile [spark-connect-gateway]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #16:
URL: https://github.com/apache/spark-connect-gateway/pull/16#issuecomment-5501021526
Thanks @dongjoon-hyun @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org