[jira] [Commented] (CMIS-297) HTTP_REQUET_TIMEOUT definition conflicts with DRUPAL 7 definition

["Cliff Ingham (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869591#comment-13869591 ] 

Cliff Ingham commented on CMIS-297:
-----------------------------------

Making these all class constants, instead of global constants would also solve the problem.

> HTTP_REQUET_TIMEOUT definition conflicts with DRUPAL 7 definition
> -----------------------------------------------------------------
>
>                 Key: CMIS-297
>                 URL: https://issues.apache.org/jira/browse/CMIS-297
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmis-phplib
>            Reporter: Richard McKnight
>            Assignee: Richard McKnight
>             Fix For: PHPCMIS 0.2
>
>
> Starting in Drupal7 HTTP_REQUEST_TIMEOUT is defined in common.inc
> It is defined as 1 as an error code in drupal_http_request.
> More information here: http://api.drupal.org/api/drupal/includes--common.inc/constant/HTTP_REQUEST_TIMEOUT/7
> Possible remedies
>   - This definition is not used in our code, so it could be commented out for now
>   - Rename just this one to something that does not conflict
>   - Rename all of the constants to something like CMIS_HTTP_REQUEST_TIMEOUT to effectively create a namespace for the constants used internally
> For now I will just change this to xHTTP_REQUEST_TIMEOUT but leave this issue open



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)