You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/02/02 23:27:32 UTC
Review Request 43116: GEODE-852: Tweak to how we copy the pulse
version properties file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43116/
-----------------------------------------------------------
Review request for geode and Jinmei Liao.
Repository: geode
Description
-------
The old way was forcing a compilation of gemfire-core in order to
generate the properties.
Using a task as the input to the copy automatically adds the task as a
dependency of the copy and the outputs of the task as the list of files
to copy.
Diffs
-----
gemfire-pulse/build.gradle 55b9e93ffea1c7b2cfb7bd19e1c3ceb2d4be9097
Diff: https://reviews.apache.org/r/43116/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 43116: GEODE-852: Tweak to how we copy the pulse
version properties file
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Feb. 2, 2016, 10:43 p.m., Jinmei Liao wrote:
> > Ship It!
nice trick. Thanks!
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43116/#review117506
-----------------------------------------------------------
On Feb. 2, 2016, 10:27 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43116/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 10:27 p.m.)
>
>
> Review request for geode and Jinmei Liao.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The old way was forcing a compilation of gemfire-core in order to
> generate the properties.
>
> Using a task as the input to the copy automatically adds the task as a
> dependency of the copy and the outputs of the task as the list of files
> to copy.
>
>
> Diffs
> -----
>
> gemfire-pulse/build.gradle 55b9e93ffea1c7b2cfb7bd19e1c3ceb2d4be9097
>
> Diff: https://reviews.apache.org/r/43116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 43116: GEODE-852: Tweak to how we copy the pulse
version properties file
Posted by Dan Smith <ds...@pivotal.io>.
> On Feb. 2, 2016, 10:43 p.m., Jinmei Liao wrote:
> > Ship It!
>
> Jinmei Liao wrote:
> nice trick. Thanks!
Yeah, I didn't know you could do this until just now, otherwise I wouldn't have suggested the other way earlier :)
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43116/#review117506
-----------------------------------------------------------
On Feb. 2, 2016, 10:27 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43116/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 10:27 p.m.)
>
>
> Review request for geode and Jinmei Liao.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The old way was forcing a compilation of gemfire-core in order to
> generate the properties.
>
> Using a task as the input to the copy automatically adds the task as a
> dependency of the copy and the outputs of the task as the list of files
> to copy.
>
>
> Diffs
> -----
>
> gemfire-pulse/build.gradle 55b9e93ffea1c7b2cfb7bd19e1c3ceb2d4be9097
>
> Diff: https://reviews.apache.org/r/43116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 43116: GEODE-852: Tweak to how we copy the pulse
version properties file
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43116/#review117506
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Feb. 2, 2016, 10:27 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43116/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 10:27 p.m.)
>
>
> Review request for geode and Jinmei Liao.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The old way was forcing a compilation of gemfire-core in order to
> generate the properties.
>
> Using a task as the input to the copy automatically adds the task as a
> dependency of the copy and the outputs of the task as the list of files
> to copy.
>
>
> Diffs
> -----
>
> gemfire-pulse/build.gradle 55b9e93ffea1c7b2cfb7bd19e1c3ceb2d4be9097
>
> Diff: https://reviews.apache.org/r/43116/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>