You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/04/27 19:57:04 UTC

[jira] [Commented] (KNOX-892) Fix FindBugs "Dodgy Code" issues

    [ https://issues.apache.org/jira/browse/KNOX-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987471#comment-15987471 ] 

ASF subversion and git services commented on KNOX-892:
------------------------------------------------------

Commit 5cb614de4dcaf6da1a04d60db73e58306b4c6c22 in knox's branch refs/heads/master from [~lmccay]
[ https://git-wip-us.apache.org/repos/asf?p=knox.git;h=5cb614d ]

KNOX-892 - Fix FindBugs "Dodgy Code" issues (Colm O hEigeartaigh via lmccay)

> Fix FindBugs "Dodgy Code" issues
> --------------------------------
>
>                 Key: KNOX-892
>                 URL: https://issues.apache.org/jira/browse/KNOX-892
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: 0001-KNOX-892-Fix-FindBugs-Dodgy-Code-issues.patch
>
>
> This task is to fix some of the FindBugs "Dodgy Code" issues. Among the issues fixed are:
> a) Write to static variables from instance methods
> b) Replaced EMPTY_* with empty* to remove some warnings
> c) Removed some unnecessary testing for null
> d) Fixed some potential NPEs on File.listFiles() if the path refers to a file rather than a directory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)