[jira] [Commented] (KAFKA-5144) MinTimestampTracker uses confusing variable names

["Matthias J. Sax (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990952#comment-15990952 ] 

Matthias J. Sax commented on KAFKA-5144:
----------------------------------------

Makes sense. Thanks for your contribution!

> MinTimestampTracker uses confusing variable names
> -------------------------------------------------
>
>                 Key: KAFKA-5144
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5144
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.2.1
>            Reporter: Michal Borowiecki
>            Assignee: Michal Borowiecki
>            Priority: Trivial
>             Fix For: 0.11.0.0
>
>
> --When adding elements MinTimestampTracker removes all existing elements greater than the added element.--
> --Perhaps I've missed something and this is intended behaviour but I can't find any evidence for that in comments or tests.--
> {{MinTimestampTracker}} maintains a list of elements ascending by timestamp, but calls the list var {{descendingSubsequence}} -- it also get the largest element at the end and stores it in a var called {{minElem}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)