[GitHub] [iceberg] danielcweeks commented on a diff in pull request #8086: Spark 3.4: Create non-existing Tag/Branch when using CREATE OR REPLACE

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #8086:
URL: https://github.com/apache/iceberg/pull/8086#discussion_r1265555554


##########
spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateOrReplaceBranchExec.scala:
##########
@@ -32,6 +32,7 @@ case class CreateOrReplaceBranchExec(
                               ident: Identifier,
                               branch: String,
                               branchOptions: BranchOptions,
+                              createOrReplace: Boolean,

Review Comment:
   The only think I feel is a little odd is that we have two booleans that are somewhat overlapping.  It feels like we should have `create` and `replace` and if both are set to `true`, you get `createOrReplace`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org