You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "NiuBlibing (via GitHub)" <gi...@apache.org> on 2025/07/09 06:38:02 UTC
[I] feat: hide password from logs for kafka-logger [apisix]
NiuBlibing opened a new issue, #10003:
URL: https://github.com/apache/apisix/issues/10003
### Current Behavior
https://github.com/apache/apisix/blob/4ea0dda7b7afc58c2d69a4b420637e90ff2bda61/apisix/utils/batch-processor-manager.lua#L60-L61 will write kafka's password to log
### Expected Behavior
Don't log password
### Error Logs
2023/08/10 07:53:03 [warn] 10#10: *11078359 [lua] batch-processor-manager.lua:60: removing batch processor stale object, conf: {"include_resp_body":false,"required_acks":1,"cluster_name":1,"producer_batch_num":200,"producer_batch_size":1048576,"producer_max_buffering":50000,"producer_time_linger":1,"inactive_timeout":5,"include_req_body":false,"name":"kafka logger","meta_format":"default","retry_delay":1,"_meta":{"disable":false},"kafka_topic":"persistent://apisix/pro/accesslog","producer_type":"async","batch_max_size":1000,"brokers":[{"host":"127.0.0.1","sasl_config":{"password":**"token:password"**,"mechanism":"PLAIN","user":"apisix/pro"},"port":9092}],"timeout":3,"max_retry_count":0,"buffer_duration":60,"meta_refresh_interval":30}, context: ngx.timer, client: 10.1.226.250, server: 0.0.0.0:9080
### Steps to Reproduce
1. Deploy apisix with bitnami' helm
2. config kafka logger with sasl global
### Environment
- APISIX version (run `apisix version`): 3.4.1
- Operating system (run `uname -a`):
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10003: feat: hide password from logs for kafka-logger
URL: https://github.com/apache/apisix/issues/10003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop closed issue #10003: feat: hide password from logs for kafka-logger
URL: https://github.com/apache/apisix/issues/10003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "Zeeeeta (via GitHub)" <gi...@apache.org>.
Zeeeeta commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-2167645427
> > If looking at error log is a security issue then user can just as easily GET for the route configuration and see the password.
>
> @Revolyssup about your consideration, we have [secret](https://apisix.apache.org/docs/apisix/3.3/terminology/secret/) and [encrypted-storage-fields](https://apisix.apache.org/docs/apisix/plugin-develop/#encrypted-storage-fields) to hide the password
Is that encrypted-storage-fields need to be implemented by the plugin rather than I can config myself?
If so, seems it is not impleted yet?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-2969826827
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-3996452824
fixed by https://github.com/apache/apisix/pull/12474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Revolyssup commented on issue #10003: feat: hide password from logs for kafka-logger
Posted by "Revolyssup (via GitHub)" <gi...@apache.org>.
Revolyssup commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-1733147506
> Hi @NiuBlibing @Revolyssup, I think you could remove this log
Given the number of considerations to be taken to hide the password, I think your suggestion to just remove this log makes sense. I will do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: hide password from logs for kafka-logger [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-2921888198
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on issue #10003: feat: hide password from logs for kafka-logger
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-1733151743
> If looking at error log is a security issue then user can just as easily GET for the route configuration and see the password.
@Revolyssup about your consideration, we have [[secret](https://apisix.apache.org/docs/apisix/3.3/terminology/secret/)](https://apisix.apache.org/docs/apisix/3.3/terminology/secret/) and [encrypted-storage-fields](https://apisix.apache.org/docs/apisix/plugin-develop/#encrypted-storage-fields) to hide the password
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on issue #10003: feat: hide password from logs for kafka-logger
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on issue #10003:
URL: https://github.com/apache/apisix/issues/10003#issuecomment-1733144837
Hi @NiuBlibing @Revolyssup, I think you could remove this log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org