You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/07 17:23:50 UTC

[GitHub] [airflow] ashb commented on pull request #9636: invoke handleCallback on dag when manually marking a DagRun success/failed from tree view

ashb commented on pull request #9636:
URL: https://github.com/apache/airflow/pull/9636#issuecomment-655010166


   So this is definitely a missing feature but there are two problems.
   
   1. This PR doesn't have unit tests, and it needs them before it's going to be merged
   2. This ends up running the (possibly long running) callback inside the webserver request, before the response is returned to the API caller.
   
   Number 2 is quite an important one, and not an easy one to fix either -- doing this properly needs some large architectural changes :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org