Re: [PR] [SPARK-50405][SQL] Handle collation type coercion of complex data types properly [spark]

["uros-db (via GitHub)" <gi...@apache.org>]

uros-db commented on code in PR #48936:
URL: https://github.com/apache/spark/pull/48936#discussion_r1865537884


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCoercion.scala:
##########


Review Comment:
   quite a few changes here, do we have benchmarks to detect possible "regressions" (i.e. any slowdown as opposed to the previous approach)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org