[GitHub] markusthoemmes commented on a change in pull request #2421: Fix order of messages being sent by the ContainerPool.

[gi...@git.apache.org]

markusthoemmes commented on a change in pull request #2421: Fix order of messages being sent by the ContainerPool.
URL: https://github.com/apache/incubator-openwhisk/pull/2421#discussion_r124649510
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -120,11 +120,7 @@ class ContainerPool(
         // Container got removed
         case ContainerRemoved =>
             freePool.remove(sender())
-            busyPool.remove(sender())
-
-        // Activation completed
-        case ActivationCompleted =>
-            feed ! ContainerReleased
+            busyPool.remove(sender()).foreach(_ => feed ! ContainerReleased)
 
 Review comment:
   Correct. In effect this should be entirely the same as before but with less boilerplate and it actually sends the message **after** we're free again. With correct buffering upfront this completely removes the "self-send" tight-loop, which is desirable.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services