You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/23 12:10:36 UTC
[GitHub] [flink] wanglijie95 opened a new pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
wanglijie95 opened a new pull request #18450:
URL: https://github.com/apache/flink/pull/18450
## What is the purpose of the change
Document how to use the usrlib to load code in the user code class loader
## Brief change log
272b759c65511b88aab0cc322b38033e89f9f945 Document how to use the usrlib to load code in the user code class loader
## Verifying this change
docs, no tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
}, {
"hash" : "cddbb308222430731528284ee045e25f19966563",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31591",
"triggerID" : "cddbb308222430731528284ee045e25f19966563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cddbb308222430731528284ee045e25f19966563 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1039916159
@wangyang0918 The [FLINK-24897](https://issues.apache.org/jira/browse/FLINK-24897) has been merged, and according to your last comments, I have update the "Fix comments" commit. Please help to review it again at your convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 272b759c65511b88aab0cc322b38033e89f9f945 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7439ecf7f6581093d661765f527bdbe37b9bed3a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809)
* 1147ab51c37c28a21f27dde7debca3cc827377fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1041180839
Merging this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18450:
URL: https://github.com/apache/flink/pull/18450#discussion_r793307538
##########
File path: docs/content.zh/docs/ops/debugging/debugging_classloading.md
##########
@@ -61,22 +61,18 @@ created for an job/application and will contain the job/application's jar files.
-->
-**Docker / Kubernetes Sessions**
+**Per-Job Mode (Yarn)**
-Docker / Kubernetes setups that start first a set of JobManagers / TaskManagers and then submit jobs/applications via REST or the CLI
-behave like standalone sessions: Flink's code is in the Java classpath, plugin components are loaded dynamically at startup and the job's code is loaded dynamically.
+Currently, only Yarn supports Per-Job mode. By default, run a Flink cluster in Per-Job mode will include the user jars
Review comment:
```suggestion
Currently, only Yarn supports Per-Job mode. By default, running a Flink cluster in Per-Job mode will include the user jars
```
##########
File path: docs/content.zh/docs/ops/debugging/debugging_classloading.md
##########
@@ -61,22 +61,18 @@ created for an job/application and will contain the job/application's jar files.
-->
-**Docker / Kubernetes Sessions**
+**Per-Job Mode (Yarn)**
-Docker / Kubernetes setups that start first a set of JobManagers / TaskManagers and then submit jobs/applications via REST or the CLI
-behave like standalone sessions: Flink's code is in the Java classpath, plugin components are loaded dynamically at startup and the job's code is loaded dynamically.
+Currently, only Yarn supports Per-Job mode. By default, run a Flink cluster in Per-Job mode will include the user jars
+(the JAR file specified in startup command and all JAR files in Flink's `usrlib` folder) into the system classpath (the *AppClassLoader*).
+This behavior can be controlled with the `yarn.per-job-cluster.include-user-jar` parameter. When setting it to `DISABLED`,
+Flink will include the user jars in the user classpath and load them dynamically by *FlinkUserCodeClassLoader*.
+See [Flink on Yarn]({{< ref "docs/deployment/resource-providers/yarn" >}}) for more details.
+**Application Mode (Standalone/Yarn/Kubernetes)**
-**YARN**
-
-YARN classloading differs between single job deployments and sessions:
-
- - When submitting a Flink job/application directly to YARN (via `bin/flink run -m yarn-cluster ...`), dedicated TaskManagers and
- JobManagers are started for that job. Those JVMs have user code classes in the Java classpath.
- That means that there is *no dynamic classloading* involved in that case for the job.
-
- - When starting a YARN session, the JobManagers and TaskManagers are started with the Flink framework classes in the
- classpath. The classes from all jobs that are submitted against the session are loaded dynamically.
+When run a Flink cluster in Application Mode(Standalone/Yarn/Kubernetes), the user jars
Review comment:
See FLINK-24897, `usrlib` is not supported for Yarn application mode now. But I believe this is the right direction that `usrlib` will be loaded by `FlinkUserCodeClassLoader` by default in application mode.
##########
File path: docs/content.zh/docs/ops/debugging/debugging_classloading.md
##########
@@ -61,22 +61,18 @@ created for an job/application and will contain the job/application's jar files.
-->
-**Docker / Kubernetes Sessions**
+**Per-Job Mode (Yarn)**
-Docker / Kubernetes setups that start first a set of JobManagers / TaskManagers and then submit jobs/applications via REST or the CLI
-behave like standalone sessions: Flink's code is in the Java classpath, plugin components are loaded dynamically at startup and the job's code is loaded dynamically.
+Currently, only Yarn supports Per-Job mode. By default, run a Flink cluster in Per-Job mode will include the user jars
+(the JAR file specified in startup command and all JAR files in Flink's `usrlib` folder) into the system classpath (the *AppClassLoader*).
+This behavior can be controlled with the `yarn.per-job-cluster.include-user-jar` parameter. When setting it to `DISABLED`,
Review comment:
```suggestion
This behavior can be controlled with the `yarn.per-job-cluster.include-user-jar` config option. When setting it to `DISABLED`,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7439ecf7f6581093d661765f527bdbe37b9bed3a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18450:
URL: https://github.com/apache/flink/pull/18450#discussion_r800374864
##########
File path: docs/content.zh/docs/deployment/resource-providers/yarn.md
##########
@@ -237,7 +237,14 @@ The configuration parameter for specifying the REST endpoint port is [rest.bind-
### User jars & Classpath
-By default Flink will include the user jars into the system classpath when running a single job. This behavior can be controlled with the [yarn.per-job-cluster.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-per-job-cluster-include-user-jar) parameter.
+**Session Mode & Application Mode**
+
+When deploying Flink with Session/Application Mode on Yarn, only the JAR file specified in startup command will be recognized as user-jars and included into user classpath.
Review comment:
For YARN application mode, the JAR file specified in startup command will be added to system classpath by default. It could also be controlled by `yarn.per-job-cluster.include-user-jar` although the name is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472545
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 272b759c65511b88aab0cc322b38033e89f9f945 (Sun Jan 23 12:14:59 UTC 2022)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 272b759c65511b88aab0cc322b38033e89f9f945 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 merged pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #18450:
URL: https://github.com/apache/flink/pull/18450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
}, {
"hash" : "cddbb308222430731528284ee045e25f19966563",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cddbb308222430731528284ee045e25f19966563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1147ab51c37c28a21f27dde7debca3cc827377fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483)
* cddbb308222430731528284ee045e25f19966563 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 272b759c65511b88aab0cc322b38033e89f9f945 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952)
* 7439ecf7f6581093d661765f527bdbe37b9bed3a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1039916159
@wangyang0918 The [FLINK-24897](https://issues.apache.org/jira/browse/FLINK-24897) has been merged, and according to your last comments, I have update the "Fix comments" commit. Please help to review it again at your convenience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a change in pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18450:
URL: https://github.com/apache/flink/pull/18450#discussion_r807481237
##########
File path: docs/content.zh/docs/ops/debugging/debugging_classloading.md
##########
@@ -61,22 +61,22 @@ created for an job/application and will contain the job/application's jar files.
-->
-**Docker / Kubernetes Sessions**
+**Per-Job Mode (Yarn)**
Review comment:
```suggestion
**Per-Job Mode (deprecated) (Yarn)**
```
##########
File path: docs/content/docs/deployment/resource-providers/yarn.md
##########
@@ -253,7 +253,14 @@ The configuration parameter for specifying the REST endpoint port is [rest.bind-
### User jars & Classpath
-By default Flink will include the user jars into the system classpath when running a single job. This behavior can be controlled with the [yarn.per-job-cluster.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-per-job-cluster-include-user-jar) parameter.
+**Session Mode**
+
+When deploying Flink with Session Mode on Yarn, only the JAR file specified in startup command will be recognized as user-jars and included into user classpath.
+
+**PerJob Mode & Application Mode**
+
+When deploying Flink with PerJob/Application Mode on Yarn, the JAR file specified in startup command and all JAR files in Flink's `usrlib` folder will be recognized as user-jars.
+By default Flink will include the user-jars into the system classpath when running a single job. This behavior can be controlled with the [yarn.classpath.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-classpath-include-user-jar) parameter.
Review comment:
```suggestion
By default Flink will include the user-jars into the system classpath. This behavior can be controlled with the [yarn.classpath.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-classpath-include-user-jar) parameter.
```
##########
File path: docs/content/docs/ops/debugging/debugging_classloading.md
##########
@@ -61,23 +61,22 @@ created for an job/application and will contain the job/application's jar files.
-->
-**Docker / Kubernetes Sessions**
+**Per-Job Mode (Yarn)**
Review comment:
```suggestion
**Per-Job Mode (deprecated) (Yarn)**
```
##########
File path: docs/content.zh/docs/deployment/resource-providers/yarn.md
##########
@@ -237,7 +237,14 @@ The configuration parameter for specifying the REST endpoint port is [rest.bind-
### User jars & Classpath
-By default Flink will include the user jars into the system classpath when running a single job. This behavior can be controlled with the [yarn.per-job-cluster.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-per-job-cluster-include-user-jar) parameter.
+**Session Mode**
+
+When deploying Flink with Session Mode on Yarn, only the JAR file specified in startup command will be recognized as user-jars and included into user classpath.
+
+**PerJob Mode & Application Mode**
+
+When deploying Flink with PerJob/Application Mode on Yarn, the JAR file specified in startup command and all JAR files in Flink's `usrlib` folder will be recognized as user-jars.
+By default Flink will include the user-jars into the system classpath when running a single job. This behavior can be controlled with the [yarn.classpath.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-classpath-include-user-jar) parameter.
Review comment:
```suggestion
By default Flink will include the user-jars into the system classpath. This behavior can be controlled with the [yarn.classpath.include-user-jar]({{< ref "docs/deployment/config" >}}#yarn-classpath-include-user-jar) parameter.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
}, {
"hash" : "cddbb308222430731528284ee045e25f19966563",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31591",
"triggerID" : "cddbb308222430731528284ee045e25f19966563",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1147ab51c37c28a21f27dde7debca3cc827377fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483)
* cddbb308222430731528284ee045e25f19966563 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31591)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1030803636
Thanks for review @wangyang0918. I've addressed all your comments. Please help to review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 272b759c65511b88aab0cc322b38033e89f9f945 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952)
* 7439ecf7f6581093d661765f527bdbe37b9bed3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7439ecf7f6581093d661765f527bdbe37b9bed3a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809)
* 1147ab51c37c28a21f27dde7debca3cc827377fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
}, {
"hash" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30809",
"triggerID" : "7439ecf7f6581093d661765f527bdbe37b9bed3a",
"triggerType" : "PUSH"
}, {
"hash" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483",
"triggerID" : "1147ab51c37c28a21f27dde7debca3cc827377fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1147ab51c37c28a21f27dde7debca3cc827377fe Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31483)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18450: [FLINK-25053][docs] Document how to use the usrlib to load code in the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18450:
URL: https://github.com/apache/flink/pull/18450#issuecomment-1019472598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "272b759c65511b88aab0cc322b38033e89f9f945",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952",
"triggerID" : "272b759c65511b88aab0cc322b38033e89f9f945",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 272b759c65511b88aab0cc322b38033e89f9f945 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29952)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org