You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "edmondchuc (via GitHub)" <gi...@apache.org> on 2026/09/25 16:47:56 UTC
[PR] GH-4259: Add GeoSPARQL geometryType function [jena]
edmondchuc opened a new pull request, #4260:
URL: https://github.com/apache/jena/pull/4260
GitHub issue resolved #4259
Add GeoSPARQL 1.1 `geof:geometryType`, returning the geometry subtype URI as an `xsd:anyURI` literal.
- Map WKT geometries to Simple Features subtype URIs.
- Preserve GML source subtypes such as `Curve` and `Surface`. For constructed GML geometries, derive the type from JTS without an XML round trip.
- Cache the resolved type on `GeometryWrapper`, preserving it across copy constructors while ensuring derived geometries compute their own type.
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5847849052
This one and #4231 have conflicts.
#4231 looks straight-forward (imports and javadoc) but overlaps with this one, and this one looks like it involves code differences.
No rush - just say on the PRs when ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "edmondchuc (via GitHub)" <gi...@apache.org>.
edmondchuc commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5851832047
Thanks, merge conflicts resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #4260:
URL: https://github.com/apache/jena/pull/4260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5854891413
Done - thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "edmondchuc (via GitHub)" <gi...@apache.org>.
edmondchuc commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5854552007
Do you want me to move `GeometryTransformIndexTest.java` under index?
`jena-geosparql/src/test/java/org/apache/jena/geosparql/implementation/index/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5854699058
Would it be easier to merge this as-is and then do that on #4261?
#4261 is then a PR on the current state of` main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "edmondchuc (via GitHub)" <gi...@apache.org>.
edmondchuc commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5854716580
Sure thing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5846674763
For the 4 open GeoSPARQL PRs, are they all good to merge now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] GH-4259: Add GeoSPARQL geometryType function [jena]
Posted by "edmondchuc (via GitHub)" <gi...@apache.org>.
edmondchuc commented on PR #4260:
URL: https://github.com/apache/jena/pull/4260#issuecomment-5847656478
@afs yes, all 4 PRs are good to go! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org