[GitHub] [hudi] novisfff commented on a diff in pull request #6383: [HUDI-4574]fixed timeline based marker thread safaty issue

[GitBox <gi...@apache.org>]

novisfff commented on code in PR #6383:
URL: https://github.com/apache/hudi/pull/6383#discussion_r946276905


##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/marker/MarkerCreationDispatchingRunnable.java:
##########
@@ -66,8 +66,9 @@ public void run() {
 
     // Only fetch pending marker creation requests that can be processed,
     // i.e., that markers can be written to a underlying file
-    for (String markerDir : markerDirStateMap.keySet()) {
-      MarkerDirState markerDirState = markerDirStateMap.get(markerDir);
+    for (Map.Entry<String, MarkerDirState> entry : markerDirStateMap.entrySet()) {
+      String markerDir = entry.getKey();
+      MarkerDirState markerDirState = entry.getValue();

Review Comment:
   > +1. @novisfff could you use [HUDI-4574](https://issues.apache.org/jira/browse/HUDI-4574) which is the original ticket for the timeline-server-based marker issue? I was investigating the issue and identified the same thread-safe problem.
   
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org