You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@beam.apache.org by Andrew Brampton <br...@gmail.com> on 2018/12/02 22:05:11 UTC

Reviews for a few changes to the Go SDK

Hi,

I've been making a few changes to the experimental Go SDK. I'm in no rush,
but per the contributors guide I'm sharing my intent, and looking for a
reviewer.

Specifically:
[BEAM-6144] Add support for the autoscalingAlgorithm flag
<https://issues.apache.org/jira/browse/BEAM-6144>
[BEAM-6155] Migrate the Go SDK to the modern GCS library
<https://issues.apache.org/jira/browse/BEAM-6155>

thanks
Andrew

Re: Reviews for a few changes to the Go SDK

Posted by Ahmet Altay <al...@google.com>.

Hi Andrew,

Following up, I reviewed both changes. Left a comment for the first one,
and merged the second one. Let me know if you need additional help.

Ahmet

On Mon, Dec 3, 2018 at 10:59 AM Ahmet Altay <al...@google.com> wrote:

> Hi Andrew,
>
>  +Robert Burke <re...@google.com> (assignee for the both JIRAs) would be a
> better reviewer but he is out of office this week. I was helping him with a
> few reviews recently and I would be happy to review your changes too in his
> absence.
>
> Since you are not in a rush, I will try to review your changes before end
> of the week.
>
> Ahmet
>
> On Sun, Dec 2, 2018 at 2:05 PM Andrew Brampton <br...@gmail.com> wrote:
>
>> Hi,
>>
>> I've been making a few changes to the experimental Go SDK. I'm in no
>> rush, but per the contributors guide I'm sharing my intent, and looking for
>> a reviewer.
>>
>> Specifically:
>> [BEAM-6144] Add support for the autoscalingAlgorithm flag
>> <https://issues.apache.org/jira/browse/BEAM-6144>
>> [BEAM-6155] Migrate the Go SDK to the modern GCS library
>> <https://issues.apache.org/jira/browse/BEAM-6155>
>>
>> thanks
>> Andrew
>>
>

Re: Reviews for a few changes to the Go SDK

Posted by Ahmet Altay <al...@google.com>.

Hi Andrew,

 +Robert Burke <re...@google.com> (assignee for the both JIRAs) would be a
better reviewer but he is out of office this week. I was helping him with a
few reviews recently and I would be happy to review your changes too in his
absence.

Since you are not in a rush, I will try to review your changes before end
of the week.

Ahmet

On Sun, Dec 2, 2018 at 2:05 PM Andrew Brampton <br...@gmail.com> wrote:

> Hi,
>
> I've been making a few changes to the experimental Go SDK. I'm in no rush,
> but per the contributors guide I'm sharing my intent, and looking for a
> reviewer.
>
> Specifically:
> [BEAM-6144] Add support for the autoscalingAlgorithm flag
> <https://issues.apache.org/jira/browse/BEAM-6144>
> [BEAM-6155] Migrate the Go SDK to the modern GCS library
> <https://issues.apache.org/jira/browse/BEAM-6155>
>
> thanks
> Andrew
>